Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] Use VM for PR license check on Buildkite #15428

Closed
wants to merge 1 commit into from

Conversation

dliappis
Copy link
Contributor

Release notes

[rn:skip]

What does this PR do?

This commit switches the license check to be run using a VM (as its currently done in Jenkins) due to the problem described in #15427.

This is a bit unfortunate because the Jenkins workflow builds a Docker image (based on Ubuntu 18.04) within the VM and then runs the check inside a container. We will address this issue and remove this unnecessary VM -> build docker image -> run inside Docker in a future PR.

Related issues

#15427.

This commit switches the license check to be run using a VM (as its
currently done in Jenkins) due to the problem described in
elastic#15427.

This is a bit unfortunate because the Jenkins workflow
builds a Docker image (based on Ubuntu 18.04) within the VM and then
runs the check inside a container. We will address this issue and
remove this unnecessary VM -> build docker image -> run inside Docker
in a future PR.
@elastic-sonarqube
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@dliappis
Copy link
Contributor Author

This is not needed, containers work fine, the problem was related to #15427

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants